Magnify light source radius rather than shape #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids various issues with lights: - For cone lights, it keeps the token footprint shape small rather than scaling up with magnification. The actual cone has its _radius_ scaled up. - For grid lights, it allows the border to follow the grid instead of being built out of larger cells (obvious when using hex grids) - For beam lights, it keeps the beamm thin while making it project further out
this allows us to consistently avoid magnifying darkness and auras without having to constantly check these conditions in `ZoneView`.
cwisniew
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #257
Description of the Change
When a sight magnifier is present, we now scale the input (light radius) rather than the output (shape). This makes cone, grid, and beam lights more well-behaved since we don't scale things that should not be scaled.
Possible Drawbacks
Light will behave a bit differently, so if someone is counting on the current behaviour they will be surprised.
Documentation Notes
Grid lights now match the shape and size of the grid when magnified.
Beam lights extend in length when magnified, but not in width.
Code lights expand their radius when magnified, but the token footprint is not scaled up.
Release Notes
This change is